Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws rds modify-certificates #33196

Closed
jrobison-sb opened this issue Aug 27, 2023 · 5 comments · Fixed by #35003
Closed

[New Resource]: aws rds modify-certificates #33196

jrobison-sb opened this issue Aug 27, 2023 · 5 comments · Fixed by #35003
Assignees
Labels
new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@jrobison-sb
Copy link
Contributor

Description

As of this writing on August 27, 2023, the default RDS CA certificate is rds-ca-2019, which expires 2024-08-22. If a user creates a new RDS instance anytime prior to 2024-08-22, and they don't explicitly request a different CA certificate via the aws_rds_instance.foo.ca_cert_identifier attribute, then presumably their instance will get this rds-ca-2019 certificate.

AWS has an API for aws rds modify-certificates, which lets you override the account-level default for new RDS instances. It would be useful if Terraform had a resource which supported this API.

If such a resource existed, a person could upgrade all their existing RDS instances to a newer and longer-duration certificate (using the aws_rds_instance.foo.ca_cert_identifier attribute), and then use this resource to set the account-level default for new instances so that they no longer have to worry about the old certificate ever being used again.

Requested Resource(s) and/or Data Source(s)

  • aws_rds_account_default_ca_certficate (or something along those lines)

Potential Terraform Configuration

resource "aws_rds_account_default_ca_certficate" "account_default" {
  certificate-identifier = "rds-ca-rsa2048-g1"
}

References

https://docs.aws.amazon.com/cli/latest/reference/rds/modify-certificates.html

https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ModifyCertificates.html

Would you like to implement a fix?

No

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Aug 27, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 27, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2023
@obounaim
Copy link
Contributor

Hi, I have PR opened for this new resource here : #35003

@ewbankkit ewbankkit self-assigned this Jul 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 11, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.59.0 milestone Jul 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 19, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants