-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: SESv2 PutAccountDetails for sandbox removal requests #32655
Comments
Community NoteVoting for Prioritization
Volunteering to Work on This Issue
|
Hey @jar-b, following the discussion here #26796 (comment), I'd be happy to work on implementing this resource. My only question would be about acceptance tests. I believe the PutAccountDetails API action submits a request for production access which is going to be reviewed and evaluated by AWS. Acceptance tests probably shouldn't submit such "fake" requests. Is there any way to work it around? |
Hey @kamilturek - thanks for your offer! Skimming the linked API docs, one potential testing option could be to focus on the attributes which don't move the account out of the This is a suggestion based on the assumption that modifying these additional attributes can be done without enabling a "production" environment. If this isn't the case, we'd likely either omit tests and add a comment to the resource explaining why, or gate the tests behind an environment variable so that are skipped unless intentionally being run to exercise this behavior. Hope this helps! |
Thanks @jar-b. I tried calling PutAccountDetails with While it shouldn't be a big problem for tests, I think it'd be a weird and unexpected side effect for users of the planned Moreover, I realized that there is no sensible way to destroy the resource. Many of the PutAccountDetails relevant fields are required so it seems impossible to bring the account details to the original state. Before calling the API for the first time, fields like |
Thanks for all this research @kamilturek.
If the same side effect happens from the console or AWS CLI, I don't think its a blocker, especially if the case automatically resolves. This would be a good point to mention in the documentation so users are aware that even changes not involving production access will trigger a support case.
If there is no way to modify them we could document that terraform-provider-aws/internal/service/lakeformation/data_lake_settings.go Lines 268 to 276 in e3609fb
|
Description
Addition of support for the SESv2 PutAccountDetails API call that enables submission of requests to move an account out of the SES sandbox.
Requested Resource(s) and/or Data Source(s)
Guessing:
Potential Terraform Configuration
References
This request was suggested at #26796 (comment) following the question in the prior comment.
The AWS API docs are at: https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_PutAccountDetails.html
Would you like to implement a fix?
No
The text was updated successfully, but these errors were encountered: