Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: resource aws_sfn_state_machine is missing DefinitionSubstitutions #32550

Open
cemeyer2 opened this issue Jul 17, 2023 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. upstream Addresses functionality related to the cloud provider.

Comments

@cemeyer2
Copy link

Description

the aws_sfn_state_machine resource is missing DefinitionSubstitutions as noted in the documentation here.

As a note, the awscc provider does already include this API parameter in its equivalent resource.

Affected Resource(s) and/or Data Source(s)

  • aws_sfn_state_machine

Potential Terraform Configuration

resource "aws_sfn_state_machine" "state_machine" {
  name       = local.step_function_name
  role_arn   = aws_iam_role.state_machine_role.arn
  definition = file("${path.module}/../../../stepfunction/state_machine.json.asl")
  logging_configuration {
    log_destination        = "${aws_cloudwatch_log_group.step_function_log_group.arn}:*"
    include_execution_data = false
    level                  = "ERROR"
  }
  definition_substitutions {
      MY_KEY = "MY VALUE"
      MY_OTHER_KEY = "MY_OTHER_VALUE"
  }
}

References

Would you like to implement a fix?

None

@cemeyer2 cemeyer2 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jul 17, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sfn Issues and PRs that pertain to the sfn service. label Jul 17, 2023
@DrFaust92 DrFaust92 added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 18, 2023
@DrFaust92
Copy link
Collaborator

This is not supported in the step function api https://docs.aws.amazon.com/step-functions/latest/apireference/API_CreateStateMachine.html#StepFunctions-CreateStateMachine-request-publish

Tagging this as upstream as provider cannot implement this directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

2 participants