Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: version 5 think there are changes when there isn't #31845

Open
shamz84 opened this issue Jun 8, 2023 · 1 comment
Open

[Bug]: version 5 think there are changes when there isn't #31845

shamz84 opened this issue Jun 8, 2023 · 1 comment
Labels
bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/iam Issues and PRs that pertain to the iam service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/sqs Issues and PRs that pertain to the sqs service. tags Pertains to resource tagging.

Comments

@shamz84
Copy link

shamz84 commented Jun 8, 2023

Terraform Core Version

0.13

AWS Provider Version

v5.1.0

Affected Resource(s)

We are experiencing this issue over a few resources such as

data "aws_iam_policy_document"
resource "aws_secretsmanager_secret"
resource "aws_sqs_queue"
resource "aws_dynamodb_table"

Expected Behavior

Ever since the upgrade to version 5, the resources tags and the the data policy aren't recognised. So when the the terraform plan run we shouldn't expect any changes.

Actual Behavior

however what does happen is that the plan interprets there are changes, which isn't the case. When we specify v4 in the provider then the TF plan still does as expected.

Relevant Error/Panic Output Snippet

~ resource "aws_dynamodb_table" "legal_cases_search_api_data_store" {
        id                          = "legal-cases-search-api-data-store"
        name                        = "legal-cases-search-api-data-store"
      ~ tags                        = {
          - "AssetGroup"    = "cdc" -> null
          - "AssetID"       = "0000" -> null
          - "AssetName"     = "xxxxx Search" -> null
          - "AssetProgram"  = "xxxxx Lexis" -> null
          - "AssetPurpose"  = "xxxxxx provide relevant search results and an improved user experience" -> null
          - "AssetSchedule" = "Exempt" -> null
            # (1 unchanged element hidden)
        }
        # (9 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Terraform Configuration Files

acdapi.terraform-20230608.1.tfplan.encrypted.zip

Steps to Reproduce

Terraform plan using v5+ you will see the following issues

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@shamz84 shamz84 added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. service/iam Issues and PRs that pertain to the iam service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/sqs Issues and PRs that pertain to the sqs service. labels Jun 8, 2023
@justinretzolk justinretzolk added tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/iam Issues and PRs that pertain to the iam service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/sqs Issues and PRs that pertain to the sqs service. tags Pertains to resource tagging.
Projects
None yet
Development

No branches or pull requests

2 participants