Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_msk_serverless_cluster to return bootstrap server url #28005

Closed
Fran-Rg opened this issue Nov 24, 2022 · 10 comments · Fixed by #32484
Closed

[Enhancement]: aws_msk_serverless_cluster to return bootstrap server url #28005

Fran-Rg opened this issue Nov 24, 2022 · 10 comments · Fixed by #32484
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. upstream Addresses functionality related to the cloud provider.
Milestone

Comments

@Fran-Rg
Copy link

Fran-Rg commented Nov 24, 2022

Description

The aws_msk_serverless_cluster recently added doesn't return the URL of the created cluster.

Now this ticket will need to be on hold, pending on aws to provide a way to programmatically retrieve that information.

As far as I can see it's not available: describe-cluster-v2 returned data doesn't have the information.

And there are no method related to client-information:
https://docs.aws.amazon.com/cli/latest/reference/kafka/index.html

Affected Resource(s) and/or Data Source(s)

  • aws_msk_serverless_cluster

Potential Terraform Configuration

* aws_msk_serverless_cluster.client_information

References

#22058

Would you like to implement a fix?

No

@Fran-Rg Fran-Rg added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/kafka Issues and PRs that pertain to the kafka service. label Nov 24, 2022
@breathingdust breathingdust added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2022
@Fran-Rg
Copy link
Author

Fran-Rg commented Nov 25, 2022

Raised it with aws, it's possible to get that information via:

aws kafka  get-bootstrap-brokers --cluster-arn "<CLUSTER_ARN>"
{
    "BootstrapBrokerStringSaslIam": "<URL>:9098"
}

https://docs.aws.amazon.com/msk/1.0/apireference/clusters-clusterarn-bootstrap-brokers.html

Either this get fetched as post resource creation or a new data is created

@yermulnik
Copy link

We've just hit this (inability to programmatically derive Serverless bootstrap endpoint) 😞
Looking forward for this to be implemented soon 🤞🏻

@yermulnik
Copy link

yermulnik commented Jan 31, 2023

Apart from amending aws_msk_serverless_cluster resource by adding cluster connection info, it also would be very much useful either to have aws_msk_broker_nodes data source amended respectively or to have a dedicated data source for Serverless MSK. Thank you.

@rpadaki
Copy link

rpadaki commented May 2, 2023

So would this be as simple as adding the following to resourceServerlessClusterRead in internal/service/kafka/serverless_cluster.go?

	brokers, _ := conn.GetBootstrapBrokers(&kafka.GetBootstrapBrokersInput{
		ClusterArn: cluster.ClusterArn,
	})
	
	d.Set("bootstrap_brokers", brokers.BootstrapBrokerString)
	d.Set("bootstrap_brokers_sasl_iam", brokers.BootstrapBrokerStringSaslIam)
	d.Set("bootstrap_brokers_public_tls", brokers.BootstrapBrokerStringPublicTls)
	...

If that's all it takes, I'm happy to put up a PR sometime in the next couple of weeks

@kaykhan
Copy link
Contributor

kaykhan commented Jul 12, 2023

I started a PR to create a new datasource that will get the endpoint via get-bootstrap-brokers request - https://docs.aws.amazon.com/cli/latest/reference/kafka/get-bootstrap-brokers.html

My first PR, so i will need help. please upvote to help with prioritization!

#32484

@github-actions github-actions bot added this to the v5.32.0 milestone Jan 11, 2024
@yermulnik
Copy link

yermulnik commented Jan 11, 2024

@ewbankkit The #32484 seems to only partially resolve this request which initially was to implement this feature via resource rather than a data source (while having data source that also does that is also desired). Can you please re-open this issue so that maybe someone can contribute by implementing Serverless MSK brokers list within aws_msk_serverless_cluster resource? Thanks.

@kaykhan I'm not entirely sure and hence am asking for your assistance: does aws_msk_bootstrap_brokers (implemented in #32484) duplicate already existing aws_msk_broker_nodes with an enhanced feature to also provide broker nodes info for Serverless MSK along with Provisioned MSK or does it provide broker nodes info only for Serverless MSK? Thanks.
It also probably makes sense to add cross-references to the documentation of aws_msk_bootstrap_brokers and aws_msk_broker_nodes data sources to eliminate confusion of why two of the same kind exist. Thanks.

Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@yermulnik
Copy link

@breathingdust Could you please look into re-opening this issue since it was resolved partially and sort of indirectly? Thanks.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants