Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missleading documentation in aws_cloudfront_distribution #21677

Open
Flojolomo opened this issue Nov 8, 2021 · 3 comments
Open

Missleading documentation in aws_cloudfront_distribution #21677

Flojolomo opened this issue Nov 8, 2021 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.

Comments

@Flojolomo
Copy link

Flojolomo commented Nov 8, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Affected resource

  • aws_cloudfront_distribution.

Issue

The documentation states the attribute max_ttl to be an optional variable. It does not mention that it defaults to 0, even if default_ttl is higher than zero.

Steps to reproduce

  • Create resource with configured default_ttl but not max_ttl in block default_cache_behavior or ordered_cache_behavior.
  • Rollout resources terraform apply
  • Requesting the resources with respond with the header x-cache: RefreshHit from cloudfront for each request
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 8, 2021
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2021
@tmccombs
Copy link
Contributor

tmccombs commented Aug 7, 2022

It seems like this might actually be a bug in the provider.

Why doesn't it default to 1 year, which is the documented default that AWS uses?

Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jul 27, 2024
@tmccombs
Copy link
Contributor

Still an issue

@github-actions github-actions bot removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.
Projects
None yet
Development

No branches or pull requests

3 participants