Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudfront_distribution should use wait_for_deployed (or new property) on destroy #13102

Open
kevinkuszyk opened this issue Apr 30, 2020 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.

Comments

@kevinkuszyk
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As we know CloudFront distributions can take some time to deploy and destroy.

We've had the wait_for_deployed property for some time now which is great. I was hoping that terraform would use that when destroying and not wait until the distribution has been deleted. Unfortunately it does not.

It would be great if we could either use this property to not wait on destroy, or add a new property for users to want to wait for deploy, but not destroy.

In my case, I don't want to wait for either.

If there is some consensus around this, I'm happy to have a stab at implementing.

New or Affected Resource(s)

  • aws_cloudfront_distribution

Potential Terraform Configuration

Maybe a new property for this. The default would be true to avoid any change in existing behaviour.

resource "aws_cloudfront_distribution" "front_end" { 
  # other properties omitted 

  wait_for_destroy = false
}
@kevinkuszyk kevinkuszyk added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 30, 2020
@ghost ghost added the service/cloudfront Issues and PRs that pertain to the cloudfront service. label Apr 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 22, 2021
@dmitriyshub
Copy link

Great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.
Projects
None yet
Development

No branches or pull requests

3 participants