From 7fc9ada394b262ef3eb0a0547b317406d5c61702 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Fri, 8 Nov 2024 14:58:21 -0500 Subject: [PATCH 1/2] dynamodb/table: TTL validation test no longer valid --- internal/service/dynamodb/table_test.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/internal/service/dynamodb/table_test.go b/internal/service/dynamodb/table_test.go index 766caae1f6c..ea287aeb935 100644 --- a/internal/service/dynamodb/table_test.go +++ b/internal/service/dynamodb/table_test.go @@ -1694,10 +1694,6 @@ func TestAccDynamoDBTable_TTL_validate(t *testing.T) { ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories, CheckDestroy: testAccCheckTableDestroy(ctx), Steps: []resource.TestStep{ - { - Config: testAccTableConfig_timeToLive(rName, "TestTTL", false), - ExpectError: regexache.MustCompile(regexp.QuoteMeta(`Attribute "ttl[0].attribute_name" cannot be specified when "ttl[0].enabled" is "false"`)), - }, { Config: testAccTableConfig_timeToLive(rName, "", true), ExpectError: regexache.MustCompile(regexp.QuoteMeta(`Attribute "ttl[0].attribute_name" cannot have an empty value`)), From 9d83ece5d8d7061f637dabcdda37bf3f012f5018 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Fri, 8 Nov 2024 15:07:16 -0500 Subject: [PATCH 2/2] Add short gates --- internal/service/dynamodb/table_test.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/internal/service/dynamodb/table_test.go b/internal/service/dynamodb/table_test.go index ea287aeb935..7f4597d207e 100644 --- a/internal/service/dynamodb/table_test.go +++ b/internal/service/dynamodb/table_test.go @@ -776,6 +776,10 @@ func TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges(t func TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned(t *testing.T) { ctx := acctest.Context(t) + if testing.Short() { + t.Skip("skipping long-running test in short mode") + } + var conf awstypes.TableDescription resourceName := "aws_dynamodb_table.test" rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix) @@ -814,6 +818,10 @@ func TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned(t *testing.T func TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest(t *testing.T) { ctx := acctest.Context(t) + if testing.Short() { + t.Skip("skipping long-running test in short mode") + } + var conf awstypes.TableDescription resourceName := "aws_dynamodb_table.test" rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix) @@ -849,6 +857,10 @@ func TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest(t *testing.T func TestAccDynamoDBTable_BillingMode_payPerRequestBasic(t *testing.T) { ctx := acctest.Context(t) + if testing.Short() { + t.Skip("skipping long-running test in short mode") + } + var conf awstypes.TableDescription resourceName := "aws_dynamodb_table.test" rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)