Skip to content

Fix resource leak #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nicolai86
Copy link

We ran into issues with *terraform.Apply where individual executions are interrupted and retried.

If an execution is interrupted without sending SIGINT terraform losses changes to the backend, breaking subsequent retries.

Some context when this happens:

  • we use the eks module eks
  • we use the pg backend for terraform

This change fixes the issue for us.

I'll try to add a minimal reproducable setup to show case in a bit.

@radeksimko
Copy link
Member

Hello @nicolai86
Thanks for the report and the contribution.

I believe #512 which leverages more of the native os/exec API, should address the mentioned issues, including the one from your TODO. The default timeout after cancellation (which now sends SIGINT instead of SIGKILL) is 60s after which SIGKILL is sent. This is also adjustable as per v0.23.0 Changelog.

Feel free to upgrade to the most recent version and let us know if this is still an issue.

@radeksimko radeksimko closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants