Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant shell definition #358

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Remove redundant shell definition #358

merged 4 commits into from
Oct 17, 2023

Conversation

rdhar
Copy link
Contributor

@rdhar rdhar commented Oct 17, 2023

Remove shell: bash from all jobs' steps since defaults: run: shell: bash has already been defined at the top of the file, which applies to all jobs in the workflow per documentation.

@rdhar rdhar requested a review from a team as a code owner October 17, 2023 12:12
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @rdhar! I have one note to address before merging 👍🏻

.github/workflows/setup-terraform.yml Show resolved Hide resolved
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks again for the PR 🚀

@austinvalle austinvalle merged commit bf6ea8a into hashicorp:main Oct 17, 2023
57 checks passed
@rdhar rdhar deleted the patch-1 branch October 17, 2023 18:37
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants