Add benchmark test for version.String() #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
radeksimko
approved these changes
Jul 4, 2025
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
Thanks, happy to merge this.
As far as I can tell, the expectation/hope is the bring all the allocations down to zero, since the benchmark measures 2nd and other subsequent String() calls, right?
Contributor
Author
|
Yes expectations is to bring down allocations to zero |
mukeshjc
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Benchmark Results:
Number of memory allocations per operation: 8 individual allocations per call to String()
This causes GC pressure and slowdowns when called in large volume systems.
If this function is called 1 million times, that’s 8 million allocations, which leads to OOM in our case.
Related Issue
#118
How Has This Been Tested?
Clone this branch and run
go test -bench=BenchmarkVersionString