feat: make Set directly JSON-unmarshable #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Set
implementsjson.Unmarshaler
, but it actually panics if you try to use it like this:This PR makes this work for
Set
, with the minor price ofnil
checks.It also makes the zero
*Set[T]
type directly usable.TreeSet
andHashSet
unfortunately cannot be made to support this without further work. The need for external definitions ofCompareFunc
/HashFunc
mean one cannot derive a usable set from the type parameters alone (see the commented-out tests).