sets: implement .Items() for use with range keyword #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a .Items() method on each of Set, HashSet, and TreeSet
enabling each type to be used with the `range` keyword for iteration.
for element := range s.Items() {
// ...
}
Note this is currently an experimental feature of Go 1.22
https://go.dev/wiki/RangefuncExperiment
shoenig
added a commit
that referenced
this pull request
Aug 15, 2024
Starting with go1.23, Go supports using `range` with custom user types
that satisfy interfaces of the `iter` package. We can make use of this
functionality for iterating over elements of each type of set.
```go
s := set.From([]int{2, 1, 1, 3})
for item := range s.Items() {
fmt.Println(item)
}
```
This functionality replaces the need for the `ForEach` defined on each
set type, and so that method is removed. This means we need a v3 breaking
change for the release.
Closes #82
shoenig
added a commit
that referenced
this pull request
Aug 16, 2024
Starting with go1.23, Go supports using `range` with custom user types
that satisfy interfaces of the `iter` package. We can make use of this
functionality for iterating over elements of each type of set.
```go
s := set.From([]int{2, 1, 1, 3})
for item := range s.Items() {
fmt.Println(item)
}
```
This functionality replaces the need for the `ForEach` defined on each
set type, and so that method is removed. This means we need a v3 breaking
change for the release.
Closes #82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a .Items() method on each of Set, HashSet, and TreeSet
enabling each type to be used with the
rangekeyword for iteration.Note this is currently an experimental feature of Go 1.22
https://go.dev/wiki/RangefuncExperiment