Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/go-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.10
Choose a base ref
...
head repository: hashicorp/go-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.5.2
Choose a head ref
  • 12 commits
  • 32 files changed
  • 3 contributors

Commits on Aug 11, 2023

  1. deps: bump protoreflect to v1.15.1 (#264)

    This bumps protoreflect to v1.15.1, which should correct some
    long-running issues WRT downstream dependencies and protoreflect's use
    of grpc_testing, unblocking downstream dependencies from upgrading the
    grpc package again.
    vancluever authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d61bc34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c578839 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Update docs for creating managed clients (#271)

    As far as I know, there is no method `NewManagedClient`, but managed clients are created using `NewClient` with `ClientConfig.Managed = true`
    Acconut authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f31f0fb View commit details
    Browse the repository at this point in the history
  2. Expose Runner interface to allow custom command runner implementations (

    #270)
    
    * Adds a new set of interfaces in a `runner` package to allow custom implementations for running plugins.
    * Adds 3 new client-facing config options:
      * `RunnerFunc` can be supplied to customise how a plugin is run, with `*exec.Cmd` treated as the spec.
      * `SkipHostEnv` tells go-plugin not to add the host process' environment variables to the command spec
      * `ReattachConfig.ReattachFunc` can be supplied to hook into running plugins that are identified by something other than a process ID
    * From a server (plugin) point of view; Adds optional environment variables to control the plugin's listener unix sockets
    * Adds `CmdRunner` as the default `Runner` implementation, maintaining existing functionality and backwards compatibility
    tomhjp authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    de19819 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Make config.Cmd and config.RunnerFunc mutually exclusive (#272)

    A set of small follow-ups to #270:
    
    * Make `ClientConfig.Cmd` and `ClientConfig.RunnerFunc` mutually exclusive
    * Clients setting `RunnerFunc` can call `ReattachConfig()` but need to supply their own `ReattachFunc` as it can't necessarily be derived from `RunnerFunc`. Exercise `ReattachConfig()` in tests in a way that previously panicked.
    * Improve 1 logger line for non-cmd implementations.
    * Add `ID()` function to client; accommodates creating a `ReattachFunc` and also useful for client's debug log information.
    tomhjp authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8b178aa View commit details
    Browse the repository at this point in the history
  2. Add context argument to runner methods that do work (#273)

    * Allows us to properly respect the start timeout for implementations that do long-running
      work in the Start method.
    * Adding context.Context to Wait and Kill makes them more consistent with Start, but is
      also a bit of a hedge, allowing room in the interface for future features without
      having to break the API.
    tomhjp authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    80216d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Add Diagnose to runner.Runner interface (#275)

    * Interface change but non-breaking as `runner.Runner` has not yet been tagged
    * Differentiate between empty line and closed channel
    * Maintain the previous first line of the error message just in case of consumers depending on it
    tomhjp authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f73a498 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1fefa8 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Consistently apply Unix socket settings (#277)

    Previously, we only supported setting the group for the server-side
    socket. This change makes it possible to set it on the client side as
    well. Also fixes a bug where the gRPC broker on the server side would
    previously not consume the directory/group environment variables.
    tomhjp authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b8dba49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2caaccb View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Add TempDir option to UnixSocketConfig (#282)

    * Add TempDir option to UnixSocketConfig. Allows clients to specify
      a folder where plugin-specific Unix socket directories should be
      created. Still defaults to $TMPDIR (if set) or /tmp.
    * Improve UnixSocketConfig field names and comments
    * Document exported Unix socket environment variables
    tomhjp authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    2f6e0c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Changelog++ for v1.5.2 (#283)

    tomhjp authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    303d84f View commit details
    Browse the repository at this point in the history
Loading