[DataShare] / [ 2019-11-01]: SDK error out when the response of delete LRO is empty

[ziyeqf]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Service Used

DataShare

API Versions Used

2019-11-01

Description

When Accouns_Delete is called, the service might return HTTP 202 without response body. While the SDK tried to unmarshal the empty body, which will error out.
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/21a8d55d74e4425e96d76e5835f52cfc9eb95a22/specification/datashare/resource-manager/Microsoft.DataShare/stable/2019-11-01/DataShare.json#L186
SDK code:

go-azure-sdk/resource-manager/datashare/2019-11-01/account/method_delete.go

Line 52 in 9527f8a

if err = resp.Unmarshal(&result.Model); err != nil {

References

No response

[tombuildsstuff]

@ziyeqf thanks for the bug report, taking a look into this now 👍

[ziyeqf]

Thanks @tombuildsstuff, the azurerm_site_recovery_fabric resource seems to have the same issue during creation.

[tombuildsstuff]

@ziyeqf indeed, checking the tests Machine Learning and a few others do too

[tombuildsstuff]

#840 - will vendor that into the Provider shortly.