Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mitchellh/hashstructure #9256

Open
dnephin opened this issue Nov 23, 2020 · 0 comments
Open

Upgrade mitchellh/hashstructure #9256

dnephin opened this issue Nov 23, 2020 · 0 comments
Labels
theme/go-modules Go modules related changes theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization

Comments

@dnephin
Copy link
Contributor

dnephin commented Nov 23, 2020

https://github.com/mitchellh/hashstructure released a V2 which fixes (mitchellh/hashstructure#18, mitchellh/hashstructure#20). If we don't persist the hashes anywhere it should be safe to upgrade. It sounds like there is a way to get the old V1 hashes if we do persist them somewhere.

Current usage:

agent/agent_endpoint.go:			rawHash, err := hashstructure.Hash(reply, nil)
agent/cache-types/connect_ca_leaf.go:	v, err := hashstructure.Hash([]interface{}{
agent/cache-types/service_checks.go:	v, err := hashstructure.Hash([]interface{}{
agent/cache-types/service_checks.go:	b, err := hashstructure.Hash(wrapper, nil)
agent/consul/discoverychain/compile.go:		v, err := hashstructure.Hash(customization, nil)
agent/structs/config_entry.go:	v, err := hashstructure.Hash([]interface{}{
agent/structs/config_entry.go:	v, err := hashstructure.Hash(struct {
agent/structs/config_entry_discoverychain.go:	v, err := hashstructure.Hash(struct {
agent/structs/intention.go:	v, err := hashstructure.Hash(q.Match, nil)
agent/structs/prepared_query.go:	v, err := hashstructure.Hash([]interface{}{
agent/structs/structs.go:	v, err := hashstructure.Hash([]interface{}{
agent/structs/structs.go:	v, err := hashstructure.Hash([]interface{}{
agent/structs/structs.go:	v, err := hashstructure.Hash([]interface{}{
agent/structs/structs.go:	v, err := hashstructure.Hash([]interface{}{
@jsosulska jsosulska added theme/go-modules Go modules related changes theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization labels Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/go-modules Go modules related changes theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization
Projects
None yet
Development

No branches or pull requests

2 participants