consul force-leave is not validating input

[samm-git]

If you have a question, please direct it to the
consul mailing list if it hasn't been
addressed in either the FAQ or in one
of the Consul Guides.

When filing a bug, please include the following:

consul version for both Client and Server

Client: 0.9.3+ent
Server: 0.9.3+ent

Description of the Issue (and unexpected/desired result)

Consul force-leave command command is not validating input. So if there is a typo or misunderstanding (e.g. using ip instead of node name) consul will silently accept it without any actions. I think it should return "node not found" or something like that.

Reproduction steps

 ~ $ consul force-leave nonexisting;echo $?
0

[hanshasselberg]

Would you accept a PR for this issue?

[kyhavlov]

We would definitely accept a PR for this, but it looks like the issue here is that the Serf library doesn't return an error when trying to call force-leave on a non-existent node. The CLI command is validating that it gets a successful response from the API, but that doesn't return an error here.

[hanshasselberg]

@kyhavlov I think I have a fix.