-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot resolve domain/FQDN while joining a exist cluster #1507
Comments
Hi @subchen the DNS resolution is being done down in here - https://github.com/hashicorp/memberlist/blob/master/memberlist.go#L218-L234. Is it possible that host has multiple IPs registered with DNS and maybe Go is picking a different one to try? |
Hi @slackpad, I only added some records in
I don't know whether the DNS resolve library only uses real DNS and skips the |
Will have to dig into Go a little bit to see what it does. |
@slackpad We experience the same issue. It seems Is there a true benefit from performing |
@kaskavalci ok this makes sense now. We want to keep the behavior of using TCP to get the largest possible list of hosts, but you are right that it breaks |
@slackpad hmm, wouldn't that include multiple IP addresses for the same host? Assume the following
We expect loopback address when we use go's lookup only but |
That's true for that example, though you'd get both addresses so the join would still work. Maybe we just need a way to turn off this TCP behavior. |
Yes Join will work but with error messages because of this line https://github.com/hashicorp/memberlist/blob/master/memberlist.go#L190 . Maybe errors for the same host will not be printed as long as one working IP is found? Or just go back to Go implementation. |
Hi @slackpad , are you OK with using only go implementation? I can send a PR for that as well. |
We had added the TCP feature in response to folks who needed the full list of severs to join, so I don't think we want to take that away. I think if we changed the code in |
Sounds OK to me. Is there a ETA for this? |
Hi, |
I did the following change myself for an easy fix https://github.com/kaskavalci/memberlist. confirmed to work. |
I use following CLI to start a consul server to join a exist cluster.
errorlogs (the resolved ip address is wrong)
That is failed to join the node2 to node1 cluster.
If I changes node1 to 192.168.1.21, that does work.
My consul version is 0.5.2
Also,
consul join <FQDN>
does not work.The text was updated successfully, but these errors were encountered: