Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when users reload with options that aren't going to be applied #1227

Open
slackpad opened this issue Sep 9, 2015 · 0 comments
Open
Labels
theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature

Comments

@slackpad
Copy link
Contributor

slackpad commented Sep 9, 2015

If a user does consul reload and changes parameters that aren't reloadable we should issue a warning to the log. Otherwise, things can get pretty confusing for users. This is the list of reloadable parameters:

https://www.consul.io/docs/agent/options.html#reloadable-configuration

This came up on #1225 where a user was trying to update their DNS TTLs. Those could actually be reloaded pretty easily, but in general it would be a good user experience to tell them that not all changes got applied in the reload. This would also be pretty easy to do by comparing the two configs minus the reloadable parts and noting any differences.

@slackpad slackpad added the type/enhancement Proposed improvement or new feature label May 3, 2017
@slackpad slackpad added theme/cli Flags and documentation for the CLI interface theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner and removed theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner labels May 25, 2017
@mkeeler mkeeler added the theme/config Relating to Consul Agent configuration, including reloading label Apr 5, 2018
@jkirschner-hashicorp jkirschner-hashicorp added the theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

3 participants