Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch handlers should get called on rpc error #1103

Open
jrmithdobbs opened this issue Jul 11, 2015 · 2 comments
Open

Watch handlers should get called on rpc error #1103

jrmithdobbs opened this issue Jul 11, 2015 · 2 comments
Labels
theme/cli Flags and documentation for the CLI interface type/enhancement Proposed improvement or new feature
Milestone

Comments

@jrmithdobbs
Copy link

When an rpc error (eg, 500 because of failure/resulting master election) occurs watches should be called in some indicative way so that action can be taken if necessary.

Things like this:

2015/07/11 03:13:33 consul.watch: Watch (type: service) errored: Unexpected response code: 500 (rpc error: unexpected EOF), retry in 5s

In the middle of consul watch <stuff> output

Also when specifying unknown datacenters:

2015/07/11 18:17:06 [ERR] http: Request /v1/health/service/something?dc=unknowndc01, error: No path to datacenter

Watches in the config/initiated from client should have a chance to fire to handle these or maybe specify a separate error handler.

@ryanuber
Copy link
Member

Thanks for the suggestion. Makes sense to me, maybe we can export an environment variable to indicate why the watch was fired. Marking as an enhancement.

@ryanuber ryanuber added the type/enhancement Proposed improvement or new feature label Jul 13, 2015
@jrmithdobbs
Copy link
Author

Even just passing a json object detailing the error instead of the normal response would be fine in my eyes.

@slackpad slackpad added the theme/cli Flags and documentation for the CLI interface label May 25, 2017
@slackpad slackpad added this to the Unplanned milestone Jan 5, 2018
@slackpad slackpad removed the post-0.9 label Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/cli Flags and documentation for the CLI interface type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

3 participants