Enhanced the refresh functionality in targets route #2889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
reviewed
Jun 17, 2025
calcaide
reviewed
Jun 17, 2025
ui/desktop/app/controllers/scopes/scope/projects/sessions/index.js
Outdated
Show resolved
Hide resolved
calcaide
previously approved these changes
Jun 17, 2025
calcaide
approved these changes
Jun 18, 2025
ZedLi
approved these changes
Jun 18, 2025
priya-patel04
approved these changes
Jun 18, 2025
sohail-hashicorp
force-pushed
the
ICU-16235/improving-refresh-ux
branch
from
e293da1 to
f9a9de9
Compare
DhariniJeeva
approved these changes
Jun 20, 2025
sohail-hashicorp
force-pushed
the
ICU-16235/improving-refresh-ux
branch
from
f9a9de9 to
0b5bc93
Compare
sohail-hashicorp
force-pushed
the
ICU-16235/improving-refresh-ux
branch
from
0b5bc93 to
a90cc1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the user experience of the refresh loading state in the target screen.
Previously, the refresh button would indicate completion while the global linear loader continued, creating user confusion.
With the current solution all refresh operations are awaited in the target route
ensuring the parent and child route refreshes complete before ending loading state.
🎟️ Jira ticket
Screenshots (if appropriate)
Issue
loading_issue.mov
In the above video, the linear loader on the header is still visible but the circular loader in the button is completed. This is due to internal loading in progress in the target route.
Fix
loading_issue_fixed.mov
How to Test
Login to the boundary and navigate to the target screen and click on refresh button.
Checklist
I have added JSON response output for API changesI have added tests that prove my fix is effective or that my feature works