Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CryptoStatic.initNodeSecurity #15825

Open
anthony-swirldslabs opened this issue Oct 4, 2024 · 0 comments
Open

Refactor CryptoStatic.initNodeSecurity #15825

anthony-swirldslabs opened this issue Oct 4, 2024 · 0 comments
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.

Comments

@anthony-swirldslabs
Copy link
Contributor

There's a EventRecoveryWorkflow in the hedera-services code that calls the CryptoStatic.initNodeSecurity method, and it does so mainly to load the private keys for the node. However, the initNodeSecurity performs a lot of other actions that are not strictly required by the recovery workflow.

Per @lpetrovic05 :

initNodeSecurity should be split into multiple methods:

  • load the private key used for signing
  • load the public keys
  • copy the public keys into the AB

initNodeSecurity can remain as is, and call into these 3 methods. Then recovery would not call initNodeSecurity , but only the first method

@anthony-swirldslabs anthony-swirldslabs added the Platform Tickets pertaining to the platform label Oct 4, 2024
@poulok poulok added the Tech Debt Reduced Issues which reduce technical debt. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants