Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformWiring not failing with incorrect types #13894

Open
timo0 opened this issue Jun 17, 2024 · 0 comments
Open

PlatformWiring not failing with incorrect types #13894

timo0 opened this issue Jun 17, 2024 · 0 comments
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.

Comments

@timo0
Copy link
Member

timo0 commented Jun 17, 2024

I updated stateSignerWiring from ComponentWiring<StateSigner, ConsensusTransactionImpl> to ComponentWiring<StateSigner, StateSignaturePayload>, not realizing that this change also required modifications in the StateSigner interface.

Symptoms:

  • Post-change, the code compiled successfully and the application ran without throwing any runtime exceptions.
  • However, the StateSigner failed to sign the state, leading to subsequent issues in the application.

Diagnosis:

  • After thorough debugging, we identified that the issue stemmed from the overlooked changes needed in the StateSigner interface.

Reference:

  • The code state before the change can be found in this branch: wiring-issue.
  • The fix for this issue was implemented in this commit: Commit 93884c9.
@timo0 timo0 added the Platform Tickets pertaining to the platform label Jun 17, 2024
@timo0 timo0 added the Tech Debt Reduced Issues which reduce technical debt. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants