Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-869 Add admin_key to the /network/nodes REST API #8757

Open
Tracked by #8516
mgoelswirlds opened this issue Jul 12, 2024 · 4 comments · May be fixed by #9776
Open
Tracked by #8516

HIP-869 Add admin_key to the /network/nodes REST API #8757

mgoelswirlds opened this issue Jul 12, 2024 · 4 comments · May be fixed by #9776
Assignees
@sdimitrov9
Labels
enhancement Type: New feature good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Good for newcomers rest Area: REST API
Milestone
0.119.0

Comments

@mgoelswirlds
Copy link
Member

mgoelswirlds commented Jul 12, 2024 •
edited by steven-sheehy
Loading

Problem

admin_key is not returned in REST API.

Solution

  • Update the /network/nodes API to return the admin_key

Alternatives

No response
@mgoelswirlds mgoelswirlds added enhancement Type: New feature rest Area: REST API labels Jul 12, 2024
@mgoelswirlds mgoelswirlds mentioned this issue Jul 12, 2024
Open
@steven-sheehy steven-sheehy changed the title Add admin_key to the /network/nodes REST API HIP-869 Add admin_key to the /network/nodes REST API Jul 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Nov 10, 2024
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Nov 10, 2024
@steven-sheehy steven-sheehy added good first issue Good for newcomers good first issue candidate Issues that can become a good first issue but need more description/context. labels Nov 10, 2024
@SvetBorislavov
Copy link

The domain_name is also missing in the response

@steven-sheehy steven-sheehy added this to the 0.119.0 milestone Nov 11, 2024
@steven-sheehy
Copy link
Member

steven-sheehy commented Nov 11, 2024 •
edited
Loading

domain_name is already present in the REST API response

@steven-sheehy steven-sheehy moved this from 🏃‍♀ Sprint backlog to 👷 In progress in Mirror Node Nov 11, 2024
@Svetoslavb04
Copy link

Correct!

@sdimitrov9 sdimitrov9 self-assigned this Nov 12, 2024
@sdimitrov9
Copy link

Feature branch: https://github.com/hashgraph/hedera-mirror-node/tree/8757-add-admin-key-to-get-nodes-endpoint

@sdimitrov9 sdimitrov9 linked a pull request Nov 18, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdimitrov9 sdimitrov9

Labels
enhancement Type: New feature good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Good for newcomers rest Area: REST API
Projects
Mirror Node
Status: 👷 In progress
Milestone
0.119.0
Development

Successfully merging a pull request may close this issue.

Add admin key to get /network/nodes endpoint hashgraph/hedera-mirror-node
5 participants
@steven-sheehy @Svetoslavb04 @mgoelswirlds @SvetBorislavov @sdimitrov9