Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta deprecate token initial balance workaround #2997

Closed
xin-hedera opened this issue Dec 13, 2021 · 0 comments · Fixed by #3088
Closed

Rosetta deprecate token initial balance workaround #2997

xin-hedera opened this issue Dec 13, 2021 · 0 comments · Fixed by #3088
Assignees
Labels
enhancement Type: New feature P2 rosetta Area: Rosetta API
Milestone

Comments

@xin-hedera
Copy link
Collaborator

xin-hedera commented Dec 13, 2021

Problem

As reported in this ticket, rosetta-cli will fail if an account has a newly associated token with non-zero balance in the current block as the tool expects a 0 balance of the token set in the previous block.

As a workaround, hedera rosetta server implementation always hides the latest block and report 0 balance of such a token in the block before the initial token account association. The cost is an extra 2 secs delay.

rosetta-sdk-go v0.7.2 fixed the issue and hedera rosetta server should deprecate the workaround

Solution

Always return the latest block in db and remove the reporting 0 token balance before token-association block workaround.

Alternatives

Leave it as is

@xin-hedera xin-hedera added enhancement Type: New feature rosetta Area: Rosetta API labels Dec 13, 2021
@xin-hedera xin-hedera self-assigned this Dec 30, 2021
@steven-sheehy steven-sheehy added this to the 0.48.0 milestone Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P2 rosetta Area: Rosetta API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants