Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts[Mirror Node] Avoid hardcoding mirror node rest API in values.yaml #410

Closed
Tracked by #111
leninmehedy opened this issue Oct 16, 2023 · 2 comments · Fixed by #413
Closed
Tracked by #111

Charts[Mirror Node] Avoid hardcoding mirror node rest API in values.yaml #410

leninmehedy opened this issue Oct 16, 2023 · 2 comments · Fixed by #413
Assignees
@leninmehedy
Labels
Blocker Further development work cannot be done Bug A error that causes the feature to behave differently than what was expected based on design docs released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Oct 16, 2023 •
edited
Loading

If we specify a RELEASE_NAME other than fst, hedera-explorer- container crashes with a log as below (note we specified RELEASE_NAME=fst2 in this example):

Image

Image

The problem occurred because in values.yaml we have hardcoded the proxyPass as below that assumes the chart is always deployed with a release name called fst. Ideally it should be like http://{{ .Release.Name }}-rest :

Image
@github-project-automation github-project-automation bot moved this to 🆕 New in FST Suite Oct 16, 2023
@leninmehedy leninmehedy mentioned this issue Oct 16, 2023
Open
@leninmehedy leninmehedy added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Oct 16, 2023
@leninmehedy leninmehedy changed the title Charts[Mirror Node] Avoid hardcoding mirror node rest API proxy in values.yaml Charts[Mirror Node] Avoid hardcoding mirror node rest API in values.yaml Oct 16, 2023
@leninmehedy leninmehedy added the Blocker Further development work cannot be done label Oct 16, 2023
This was referenced Oct 16, 2023
Closed
Closed
@leninmehedy
Copy link
Member Author

leninmehedy commented Oct 16, 2023 •
edited
Loading

Added fix in mirror-node-explorer here: hashgraph/hedera-mirror-node-explorer#726

We need that PR to be merged so that we can merge our PR: #413

@leninmehedy leninmehedy mentioned this issue Oct 16, 2023
Merged
@leninmehedy leninmehedy self-assigned this Oct 16, 2023
@leninmehedy leninmehedy moved this from 🆕 New to 👀 In review in FST Suite Oct 16, 2023
@leninmehedy leninmehedy moved this from 👀 In review to Blocked in FST Suite Oct 16, 2023
@leninmehedy leninmehedy removed the status in FST Suite Oct 16, 2023
@leninmehedy leninmehedy moved this to Blocked in FST Suite Oct 16, 2023
@github-project-automation github-project-automation bot moved this from ✋ Blocked to ✅ Done in FST Suite Oct 18, 2023
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leninmehedy leninmehedy

Labels
Blocker Further development work cannot be done Bug A error that causes the feature to behave differently than what was expected based on design docs released
Projects
FST Suite
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid hardcoding mirror-node-explorer rest API in values.yaml hashgraph/full-stack-testing
2 participants
@leninmehedy @swirlds-automation