Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts[Network Node]: Add support for targeting node labels, taints, and affinity/anti-affinity #344

Closed
Tracked by #111
nathanklick opened this issue Sep 14, 2023 · 2 comments · Fixed by #352
Closed
Tracked by #111

Charts[Network Node]: Add support for targeting node labels, taints, and affinity/anti-affinity #344

nathanklick opened this issue Sep 14, 2023 · 2 comments · Fixed by #352
Assignees
@leninmehedy
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released
Milestone
v0.9.x

Comments

@nathanklick
Copy link
Member

nathanklick commented Sep 14, 2023 •
edited
Loading

Description

Add support to our Helm chart for node labels, taints, affinity, and annotations along the lines of the following:

podAnnotations: {}

podLabels: {}

nodeSelector: {}

tolerations: []

affinity: {}

# Only one of minAvailable or maxUnavailable can be set
podDisruptionBudget:
  enabled: false
  # minAvailable: 1
  # maxUnavailable: 3

# Leverage a PriorityClass to ensure your pods survive resource shortages
# ref: https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/
# PriorityClass: system-cluster-critical
priorityClassName: ""
@github-project-automation github-project-automation bot moved this to 🆕 New in FST Suite Sep 14, 2023
@nathanklick nathanklick mentioned this issue Sep 14, 2023
Open
@nathanklick nathanklick added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Sep 14, 2023
@nathanklick nathanklick added this to the v0.9.x milestone Sep 14, 2023
@nathanklick nathanklick moved this from 🆕 New to 🔖 Ready in FST Suite Sep 14, 2023
@leninmehedy leninmehedy moved this from 🔖 Ready to 🏗 In progress in FST Suite Sep 18, 2023
@leninmehedy leninmehedy linked a pull request Sep 18, 2023 that will close this issue
feat: add support for scheduling pods based on node labels, taints, and affinity #352
Merged
@leninmehedy leninmehedy mentioned this issue Sep 18, 2023
Merged
@leninmehedy
Copy link
Member

leninmehedy commented Sep 18, 2023 •
edited
Loading

Need a bit more clarity on the requirements of the following before I update the charts:

  • podDisruptionBudget
  • priorityClassName

We can create separate tickets for these if necessary.

@leninmehedy leninmehedy moved this from 🏗 In progress to 🔖 Ready in FST Suite Sep 20, 2023
@leninmehedy leninmehedy moved this from 🔖 Ready to 🏗 In progress in FST Suite Sep 21, 2023
@leninmehedy leninmehedy moved this from 🏗 In progress to 👀 In review in FST Suite Sep 21, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in FST Suite Oct 4, 2023
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leninmehedy leninmehedy

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released
Projects
FST Suite
Status: ✅ Done
Milestone
v0.9.x
3 participants
@leninmehedy @nathanklick @swirlds-automation