Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts[Network Node]: Use reasonable defaults for the per node configuration in the values.yaml file #206

Closed
Tracked by #111
nathanklick opened this issue Aug 1, 2023 · 2 comments · Fixed by #229
Assignees
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. released on @0.5.x released
Milestone

Comments

@nathanklick
Copy link
Member

nathanklick commented Aug 1, 2023

User Story

As a Helm chart user,

I should

be able to run the chart with minimal configuration to the list of nodes.

So that

I do not need to explicitly specify every option repetitively

and

I only need to override specific configuration items when necessary.

Related Issues

Requested Changes

  • Ensure all node properties shown below in the current config section, except for the name are defaulted if not explicitly defined.
  • Ensure the resulting config per node can be simplified to the following definition when no overrides are required:
     - name: node0
     - name: node1
     - name: node2
     - name: node3
    

Current Config

    - name: node0
      resources:
        requests:
          cpu: 100m
          memory: 1G
        limits:
          cpu: 100m
          memory: 1G
      root:
        image:
          registry: ghcr.io
          repository: hashgraph/full-stack-testing/ubi8-init-dind
          tag: "0.3.0"  # Defaults to the chart's app version if empty
          pullPolicy: IfNotPresent
      haproxy:
        image:
          registry: docker.io
          repository: haproxy
          tag: "2.4-alpine"  # Defaults to the chart's app version if empty
          pullPolicy: IfNotPresent
        replica: 1
      envoyProxy:
        image:
          registry: docker.io
          repository: envoyproxy/envoy
          tag: "v1.21.1"  # Defaults to the chart's app version if empty
          pullPolicy: IfNotPresent
        replica: 1
      sidecars:
        recordStreamUploader:
          enabled: true
          nameOverride: "record-stream-uploader"
          image:
            registry: gcr.io
            repository: hedera-registry/uploader-mirror
            tag: "1.3.0"  # Defaults to the chart's app version if empty
            pullPolicy: IfNotPresent
          config:
            debug: true
            compression: true
            sidecar: true
            reaper:
              enable: true
              minKeep: 1
              interval: 1
              defaultBackoff: 1
            signature:
              require: true
              prioritize: true
        eventStreamUploader:
          enabled: true
          nameOverride: "event-stream-uploader"
          image:
            registry: gcr.io
            repository: hedera-registry/uploader-mirror
            tag: "1.3.0"  # Defaults to the chart's app version if empty
            pullPolicy: IfNotPresent
          config:
            debug: true
            compression: true
            reaper:
              enable: true
              minKeep: 1
              interval: 1
              defaultBackoff: 1
            signature:
              require: true
              prioritize: true
        accountBalanceUploader:
          enabled: true
          nameOverride: "account-balance-uploader"
          image:
            registry: gcr.io
            repository: hedera-registry/uploader-mirror
            tag: "1.3.0"  # Defaults to the chart's app version if empty
            pullPolicy: IfNotPresent
          config:
            debug: true
            compression: true
            reaper:
              enable: true
              minKeep: 1
              interval: 1
              defaultBackoff: 1
            signature:
              require: true
              prioritize: true
        backupUploader:
          enabled: true
          nameOverride: "backup-uploader"
          image:
            registry: gcr.io
            repository: "hedera-registry/hedera-backups"
            tag: "0.6.0"
            pullPolicy: IfNotPresent
          config:
            backupBucket: "backup"
        otelCollector:
          enabled: true
          nameOverride: "otel-collector"
          image:
            registry: docker.io
            repository: "otel/opentelemetry-collector-contrib"
            tag: "0.72.0"
            pullPolicy: IfNotPresent
#          resources:
#            requests:
#              cpu: 100m
#              memory: 1G
#            limits:
#              cpu: 100m
#              memory: 1G
          config: {}
@github-project-automation github-project-automation bot moved this to 🆕 New in FST Suite Aug 1, 2023
@nathanklick nathanklick moved this from 🆕 New to 🔖 Ready in FST Suite Aug 1, 2023
@nathanklick nathanklick added this to the v0.5.0 milestone Aug 1, 2023
@nathanklick nathanklick added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Aug 1, 2023
@leninmehedy leninmehedy moved this from 🔖 Ready to 🏗 In progress in FST Suite Aug 1, 2023
@leninmehedy leninmehedy moved this from 🏗 In progress to 👀 In review in FST Suite Aug 2, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in FST Suite Aug 3, 2023
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. released on @0.5.x released
Projects
Status: ✅ Done
3 participants