Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts[Network Node]: Ensure CI pipeline tests network node installation #202

Closed
Tracked by #111
nathanklick opened this issue Jul 31, 2023 · 2 comments · Fixed by #228
Closed
Tracked by #111

Charts[Network Node]: Ensure CI pipeline tests network node installation #202

nathanklick opened this issue Jul 31, 2023 · 2 comments · Fixed by #228
Assignees
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone. released on @0.5.x released
Milestone

Comments

@nathanklick
Copy link
Member

nathanklick commented Jul 31, 2023

User Story

As a software engineer,

I want

the CI pipeline, for both manual and PR based triggered runs, to perform all available Helm chart tests.

So that

I can be assured my changes did not break the Helm chart.

Assumptions

  • The helm test command runs all available tests.

Requested Changes

  • Add the following workflow level permissions near the top of the zxc-compile-code.yaml CI workflow:
     permissions:
          id-token: write
          contents: read
    
  • Add the following GCP authentication steps to the zxc-compile-code.yaml CI workflow:
        - name: Authenticate to Google Cloud
          id: google-auth
          uses: google-github-actions/auth@ef5d53e30bbcd8d0836f4288f5e50ff3e086997d # pin@v1
          with:
            token_format: 'access_token'
            workload_identity_provider: "projects/101730247931/locations/global/workloadIdentityPools/hedera-registry-pool/providers/hedera-registry-gh-actions"
            service_account: "swirlds-automation@hedera-registry.iam.gserviceaccount.com"
    
        - name: Setup Google Cloud SDK
          uses: google-github-actions/setup-gcloud@d51b5346f85640ec2aa2fa057354d2b82c2fcbce # pin@v1
    
  • Update the Makefile to add the setup-nodes and start-nodes targets as prerequisite for the test target.
  • Update the CI pipeline to run both NMT and Direct install variants:
    • make test SCRIPT_NAME=direct-install.sh
    • make test SCRIPT_NAME=nmt-install.sh
@github-project-automation github-project-automation bot moved this to 🆕 New in FST Suite Jul 31, 2023
@nathanklick nathanklick added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone. labels Jul 31, 2023
@nathanklick nathanklick added this to the v0.5.0 milestone Jul 31, 2023
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🏗 In progress in FST Suite Jul 31, 2023
@nathanklick nathanklick moved this from 🏗 In progress to 👀 In review in FST Suite Aug 1, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in FST Suite Aug 2, 2023
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone. released on @0.5.x released
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants