Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PySide2 support #99

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add PySide2 support #99

wants to merge 9 commits into from

Conversation

me21
Copy link

@me21 me21 commented Sep 14, 2018

This is a combination of PRs #87, #88 and #97. I've taken care of reported merge conflicts.

zhang-peter and others added 8 commits December 26, 2017 10:44
Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
…ng matrix - it wasn't tested actually. Brought appveyor.yml in sync with testing matrix.

Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
@me21
Copy link
Author

me21 commented Sep 15, 2018

Er, the errors on AppVeyor seem nothing to do with the changes.

  • PySide on Python 3.4 just returned non-zero exit code, even though the tests have passed.
  • PyQt4/5 on Python 3.4 failed to install the prerequisites (perhaps some temporary connection problems with PyPI repository?)
  • PyQt5 on Python 3.5 complained about PATH in the log, so I suspect it couldn't find some executables or libraries.

I've noticed two syntax errors in Linux builds which caused PySide and PySide2 to be skipped from testing, I'll fix these and rerun all the tests, though.

… for troubleshooting PATH errors.

Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
@me21
Copy link
Author

me21 commented Sep 15, 2018

Okay, PATH errors seem to be harmless since they happen in succesful builds too.
Anyway, these build errors in some of the environments look like they aren't caused by the source code.
For example, import errors in PyQt5 and Python 3.5 are caused by known incompatibility between PyQt5.11 and Python <= 3.5.3: https://riverbankcomputing.com/pipermail/pyqt/2018-July/040514.html

And AppVeyor has exactly Python 3.5.3. When it upgrades to Python 3.5.4, the problem should go away.

@me21
Copy link
Author

me21 commented Sep 15, 2018

Another incompatibility is that PySide2 requires Qt 5.11 to be built on Linux, and .travis.yml currently installs Qt 5.9. This needs to be fixed. @harvimt?

Copy link

@ctismer ctismer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should that be? QtGui.QApplication is for sure not in PySide2.

@me21
Copy link
Author

me21 commented Oct 27, 2018

Yes, QApplication is in QtWidgets there, not in QtGui. It is taken care of in that commit.
I'm afraid I don't fully understand your question. Can you please give me more details on what needs to be done?

@henry232323
Copy link
Contributor

Is this going to be implemented any time soon?

@ghost
Copy link

ghost commented Sep 22, 2019

so pyside2 dead for quamash?, @harvimt will there be updates or what else to use pyside2 + qt5 on python3? also: #100

@harvimt
Copy link
Owner

harvimt commented Oct 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants