-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PySide2 support #99
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
…ng matrix - it wasn't tested actually. Brought appveyor.yml in sync with testing matrix. Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Er, the errors on AppVeyor seem nothing to do with the changes.
I've noticed two syntax errors in Linux builds which caused PySide and PySide2 to be skipped from testing, I'll fix these and rerun all the tests, though. |
… for troubleshooting PATH errors. Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Okay, PATH errors seem to be harmless since they happen in succesful builds too. And AppVeyor has exactly Python 3.5.3. When it upgrades to Python 3.5.4, the problem should go away. |
Another incompatibility is that PySide2 requires Qt 5.11 to be built on Linux, and .travis.yml currently installs Qt 5.9. This needs to be fixed. @harvimt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should that be? QtGui.QApplication is for sure not in PySide2.
Yes, QApplication is in QtWidgets there, not in QtGui. It is taken care of in that commit. |
Is this going to be implemented any time soon? |
the test-2019 branch mostly works, but hasn't been tested thoroughly.
…On Sun, Sep 22, 2019 at 4:07 AM hivemall ***@***.***> wrote:
so pyside2 dead for quamash, @harvimt <https://github.com/harvimt> will
there be updates or what else to use pyside2 + qt5 on python3?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#99?email_source=notifications&email_token=AAA5CQUTPJXQGE4JD2WON7DQK5GW3A5CNFSM4FVIL4A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JD4YQ#issuecomment-533872226>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA5CQV2BHF64KEPPICB3S3QK5GW3ANCNFSM4FVIL4AQ>
.
|
This is a combination of PRs #87, #88 and #97. I've taken care of reported merge conflicts.