fixed more resharper issues

Author: janwilmans

DebugView++/LogView.cpp

@@ -278,7 +278,7 @@ void CLogView::UpdateColumns()
 
 ColumnInfo MakeColumn(Column::type column, const wchar_t* name, int format, int width)
 {
-	ColumnInfo info = {0};
+	auto info = ColumnInfo();
 	info.enable = true;
 	info.column.iSubItem = column;
 	info.column.iOrder = column;
@@ -1801,6 +1801,7 @@ bool FilterSupportsColor(FilterType::type value)
 	case FilterType::Stop:
 	case FilterType::Once:
 		return true;
+	default: break;
 	}
 	return false;
 }

DebugView++/PropertyColorItem.h

@@ -106,7 +106,7 @@ class CPropertyColorItem : public CPropertyItem
 		m_dlg.ShowAuto(show);
 	}
 
-    virtual BOOL Activate(UINT action, LPARAM /*lParam*/) override
+	virtual BOOL Activate(UINT action, LPARAM /*lParam*/) override
 	{
 		if (!IsEnabled())
 			return FALSE;
@@ -119,15 +119,16 @@ class CPropertyColorItem : public CPropertyItem
 			if (m_dlg.DoModal(m_hWndOwner) == IDOK)
 			{
 				// Let control owner know
-				NMPROPERTYITEM nmh = { m_hWndOwner, ::GetDlgCtrlID(m_hWndOwner), PIN_ITEMCHANGED, this };
-				::SendMessage(::GetParent(m_hWndOwner), WM_NOTIFY, nmh.hdr.idFrom, (LPARAM) &nmh);
+				NMPROPERTYITEM nmh = {m_hWndOwner, ::GetDlgCtrlID(m_hWndOwner), PIN_ITEMCHANGED, this};
+				::SendMessage(::GetParent(m_hWndOwner), WM_NOTIFY, nmh.hdr.idFrom, reinterpret_cast<LPARAM>(&nmh));
 			}
 			break;
+		default: break;
 		}
 		return TRUE;
 	}
 
-    virtual void DrawValue(PROPERTYDRAWINFO& di) override
+	virtual void DrawValue(PROPERTYDRAWINFO& di) override
 	{
 		CDCHandle dc(di.hDC);
 		RECT rect = di.rcItem;
@@ -152,13 +153,13 @@ class CPropertyColorItem : public CPropertyItem
 		}
 	}
 
-    virtual BOOL GetValue(VARIANT* pValue) const override
+	virtual BOOL GetValue(VARIANT* pValue) const override
 	{
 		CComVariant var(GetColor());
 		return SUCCEEDED(var.Detach(pValue));
 	}
 
-    virtual BOOL SetValue(const VARIANT& value) override
+	virtual BOOL SetValue(const VARIANT& value) override
 	{
 		CComVariant var;
 		if (FAILED(VariantChangeType(&var, &value, 0, VT_COLOR)))

DebugView++/SourceDlg.cpp

@@ -68,7 +68,7 @@ void CSourceDlg::OnException(const std::exception& ex)
 BOOL CSourceDlg::OnInitDialog(CWindow /*wndFocus*/, LPARAM /*lInitParam*/)
 {
 	CenterWindow(GetParent());
-	CComboBox combo = GetDlgItem(IDC_TYPE);
+	CComboBox combo(GetDlgItem(IDC_TYPE));
 	combo.AddString(WStr(SourceTypeToString(SourceType::Udp)));
 	combo.AddString(WStr(SourceTypeToString(SourceType::Tcp)));
 	combo.AddString(WStr(SourceTypeToString(SourceType::DebugViewAgent)));

DebugView++Lib/Colors.cpp

@@ -41,6 +41,7 @@ COLORREF HsvToRgb(double h, double s, double v)
 	case 3: return RGB(pi, qi, vi);
 	case 4: return RGB(ti, pi, vi);
 	case 5: return RGB(vi, pi, qi);
+	default: break;
 	}
 	return 0;
 }

DebugView++Lib/DbgviewReader.cpp

@@ -64,7 +64,7 @@ std::string ToHex(const T& s)
 	result << "[" << s.size() << "] ";
 
 	for (size_t i = 0; i < s.size(); ++i)
-		result << std::hex << std::setfill('0') << std::setw(2) << std::uppercase << ((int)s[i] & 0xff) << " ";
+		result << std::hex << std::setfill('0') << std::setw(2) << std::uppercase << (static_cast<int>(s[i]) & 0xff) << " ";
 	return result.str();
 }
 
@@ -78,7 +78,7 @@ std::string ToChar(const T& s)
 	{
 		if (s[i] > 32)
 		{
-			result << std::setfill(' ') << std::setw(2) << (char)s[i] << " ";
+			result << std::setfill(' ') << std::setw(2) << static_cast<char>(s[i]) << " ";
 		}
 		else
 		{

DebugView++Lib/FileIO.cpp

@@ -119,7 +119,7 @@ FileType::type IdentifyFile(const std::wstring& filename)
 		// Encoding detection is very complex, see #107
 		std::ifstream fs(filename, std::ios::binary);
 		std::vector<unsigned char> buffer(3);
-		fs.read((char*)buffer.data(), buffer.size());
+		fs.read(reinterpret_cast<char*>(buffer.data()), buffer.size());
 		if (buffer[0] == 0xfe && buffer[1] == 0xff)
 		{
 			return FileType::UTF16BE;

DebugView++Lib/PolledLogSource.cpp

@@ -57,7 +57,7 @@ PolledLogSource::PolledLogSource(Timer& timer, SourceType::type sourceType, ILin
 
 PolledLogSource::~PolledLogSource()
 {
-	Abort();
+	PolledLogSource::Abort();
 }
 
 void PolledLogSource::StartThread()

DebugViewConsole/DebugViewConsole.cpp

@@ -291,11 +291,11 @@ fusion::debugviewpp::Settings CreateSettings(const std::map<std::string, docopt:
 	settings.tabs = args.at("-q").asBool();
 	settings.pid = args.at("-p").asBool();
 	settings.processName = args.at("-n").asBool();
-    settings.include = args.at("--include").asStringList();
-    settings.exclude = args.at("--exclude").asStringList();
-    settings.includeprocesses = args.at("--include-process").asStringList();
-    settings.excludeprocesses = args.at("--exclude-process").asStringList();
-    auto quitmessageEntry = args.at("--quit-message");
+	settings.include = args.at("--include").asStringList();
+	settings.exclude = args.at("--exclude").asStringList();
+	settings.includeprocesses = args.at("--include-process").asStringList();
+	settings.excludeprocesses = args.at("--exclude-process").asStringList();
+	auto quitmessageEntry = args.at("--quit-message");
 	settings.quitmessage = (quitmessageEntry) ? quitmessageEntry.asString() : "";
 	return settings;
 }

plugins/cs/HttpMonitor/Program.cs

@@ -126,7 +126,7 @@ public List<string> Get()
 
 	static class Util
 	{
-		static public void DebugWrite(string msg)
+		public static void DebugWrite(string msg)
 		{
 			Console.WriteLine(msg);
 			Trace.WriteLine(msg);
@@ -135,9 +135,9 @@ static public void DebugWrite(string msg)
 
 	static class Settings
 	{
-		static public bool Verbose;
-		static public int PollInterval = 5000;
-		static public int HttpTimeout = 5000;
+		public static bool Verbose;
+		public static int PollInterval = 5000;
+		public static int HttpTimeout = 5000;
 	}
 
 	class DebugViewPlugin