Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI 1.43 RN. #7773

Merged
merged 3 commits into from
Aug 26, 2024
Merged

CI 1.43 RN. #7773

merged 3 commits into from
Aug 26, 2024

Conversation

dewan-ahmed
Copy link
Collaborator

Description

PR lifecycle

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@dewan-ahmed dewan-ahmed added Release notes This PR includes release notes Review - PM Needs review from PM labels Aug 26, 2024
@dewan-ahmed dewan-ahmed self-assigned this Aug 26, 2024
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66cca374fb816a27bc61c9c4--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66ccb9d4fb816a42e461c572--harness-developer.netlify.app


- Resolved an issue where artifacts did not appear in the artifacts tab of the CI stage when using the 'build and push' steps with Buildx instead of Kaniko. (CI-13576, ZD-63222,65912)

- Fixed `NodeSelector` field label visibility. The reference for the node selector string has been corrected to ensure the label is properly populated. (CI-13867)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not clear what this issue is about. the other items look find to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this help: 809a87a ?

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66ccbf98c581fe49ac8a510a--harness-developer.netlify.app

Copy link
Collaborator

@nofarblue nofarblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dewan-ahmed dewan-ahmed merged commit 96821a1 into harness:main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release notes This PR includes release notes Review - PM Needs review from PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants