[rpc] support for eip-1898 - support block number or hash on state-related methods #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peekpi
commented
May 28, 2022
| if header == nil && err != nil { | ||
| return | ||
| } | ||
| state, err := s.hmy.BeaconChain.StateAt(header.Root()) |
There was a problem hiding this comment.
@rlan35 do you know why here use BeaconChain but BlockChain? what's the difference between them?
peekpi
commented
May 28, 2022
| @@ -69,7 +69,7 @@ func (s *AccountAPI) AccountBalance( | |||
| return nil, rosettaError | |||
| } | |||
| } else { | |||
| balance, err = s.hmy.GetBalance(ctx, addr, blockNum) | |||
| balance, err = s.hmy.GetBalance(ctx, addr, rpc.BlockNumberOrHashWithNumber(blockNum)) | |||
There was a problem hiding this comment.
@LuttyYang please help to check the change of rosetta
|
@peekpi can you attach rpc call result test in the PR showing we still support the old way along with the new ones |
travis_rpc_test already has some tests for the old RPC. |
|
Tested on mainnet archival node by block numberby blockhash inside an object |
rlan35
approved these changes
May 31, 2022
sophoah
changed the title
sophoah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge ethereum/go-ethereum#19491 to harmony.