Skip to content

Enable networkidle2 tests #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kblok wants to merge 3 commits into
base: v21
Choose a base branch
from
Open

Enable networkidle2 tests #3031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc5404e
Enable networkidle2 tests
kblok Dec 6, 2025
4359856
ignore failing test
kblok Dec 7, 2025
a9354b0
Merge branch 'v21' into enable-some-bidi-tests
kblok Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 16 additions & 30 deletions lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,6 @@
"parameters": ["firefox"],
"expectations": ["FAIL"]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[browser.spec] *should not return child_process for remote browser*",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[navigation.spec] navigation Page.waitForNavigation*should work with clicking on anchor links",
Expand Down Expand Up @@ -194,21 +179,6 @@
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[navigation.spec] *should navigate to empty page with networkidle2*",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[navigation.spec] *should navigate to empty page with networkidle0*",
Expand Down Expand Up @@ -1259,5 +1229,21 @@
"expectations": [
"SKIP"
]
},
{
"comment": "Firefox BiDi doesn't support multiple sessions on the same browser",
"testIdPattern": "[browser.spec] Browser.process should not return child_process for remote browser",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"firefox",
"webDriverBiDi"
],
"expectations": [
"SKIP"
]
}
]
Loading