Skip to content

Commit 84c4a9d

Browse files
Cong Wangdavem330
authored andcommitted
xfrm6: release dev before returning error
We forget to call dev_put() on error path in xfrm6_fill_dst(), its caller doesn't handle this. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Cong Wang <amwang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5dbd506 commit 84c4a9d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

net/ipv6/xfrm6_policy.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,10 @@ static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev,
103103
dev_hold(dev);
104104

105105
xdst->u.rt6.rt6i_idev = in6_dev_get(dev);
106-
if (!xdst->u.rt6.rt6i_idev)
106+
if (!xdst->u.rt6.rt6i_idev) {
107+
dev_put(dev);
107108
return -ENODEV;
109+
}
108110

109111
rt6_transfer_peer(&xdst->u.rt6, rt);
110112

0 commit comments

Comments
 (0)