Fix some slcan issues #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow partial messages to be received Fix DLC for remote frames Add unit test
christiansandberg
force-pushed
the
slcan-fixes
branch
from
8ad64b2 to
247df08
Compare
Codecov Report
@@ Coverage Diff @@
## develop #447 +/- ##
===========================================
- Coverage 62.42% 59.01% -3.42%
===========================================
Files 55 55
Lines 4665 4672 +7
===========================================
- Hits 2912 2757 -155
- Misses 1753 1915 +162 |
can/interfaces/slcan.py
Outdated
|
|
||
| if pos != -1: | ||
| readStr = self._buffer[0:pos].decode() | ||
| del self._buffer[0:pos] |
There was a problem hiding this comment.
Note to self: should be pos+1.
felixdivo
reviewed
Oct 5, 2018
felixdivo
requested changes
Oct 5, 2018
felixdivo
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow partial messages to be received
Fix DLC for remote frames
Add unit test
Fixes #444