clippy fixes

Author: haraldng

omnipaxos/src/omni_paxos.rs

@@ -152,8 +152,7 @@ impl ClusterConfig {
 /// Configuration for a singular `OmniPaxos` instance in a cluster.
 /// # Fields
 /// * `pid`: The unique identifier of this node. Must not be 0.
-/// * `election_tick_timeout`: The number of calls to `tick()` before leader election is updated.
-/// If this is set to 5 and `tick()` is called every 10ms, then the election timeout will be 50ms. Must not be 0.
+/// * `election_tick_timeout`: The number of calls to `tick()` before leader election is updated. If this is set to 5 and `tick()` is called every 10ms, then the election timeout will be 50ms. Must not be 0.
 /// * `resend_message_tick_timeout`: The number of calls to `tick()` before a message is considered dropped and thus resent. Must not be 0.
 /// * `buffer_size`: The buffer size for outgoing messages.
 /// * `batch_size`: The size of the buffer for log batching. The default is 1, which means no batching.

omnipaxos/src/unicache/lfu/mod.rs

@@ -86,18 +86,18 @@ impl<K: Hash + Eq + Clone, V> LFUCache<K, V> {
     /// Method marked as mutable because it internally updates the frequency of the accessed key
     pub fn get(&mut self, key: &K) -> Option<&V> {
         self.update_frequency_bin(key);
-        self.values.get(&key).map(|x| &x.value)
+        self.values.get(key).map(|x| &x.value)
     }
 
     pub fn get_mut(&mut self, key: &K) -> Option<&mut V> {
         self.update_frequency_bin(key);
-        self.values.get_mut(&key).map(|x| &mut x.value)
+        self.values.get_mut(key).map(|x| &mut x.value)
     }
 
     fn update_frequency_bin(&mut self, key: &K) {
-        if let Some(value_counter) = self.values.get_mut(&key) {
+        if let Some(value_counter) = self.values.get_mut(key) {
             let bin = self.frequency_bin.get_mut(&value_counter.count).unwrap();
-            bin.0.remove(&key);
+            bin.0.remove(key);
             let count = value_counter.count;
             value_counter.inc();
             if count == self.min_frequency && bin.0.is_empty() {

omnipaxos/src/unicache/lfu/serialization.rs

@@ -13,7 +13,7 @@ where
     {
         let len = self.0.len();
         let mut seq = serializer.serialize_seq(Some(len))?;
-        let _ = self.0.iter().for_each(|item| {
+        self.0.iter().for_each(|item| {
             seq.serialize_element(&item).unwrap();
         });
         seq.end()

omnipaxos/src/unicache/lfu_cache.rs

@@ -52,7 +52,7 @@ where
     }
 
     fn try_encode(&mut self, field: &Encodable) -> MaybeEncoded<Encodable, Encoded> {
-        match self.lfu_cache_encoder.get(&field) {
+        match self.lfu_cache_encoder.get(field) {
             Some(encoding) => MaybeEncoded::<Encodable, Encoded>::Encoded(encoding.clone()),
             None => {
                 if self.lfu_cache_encoder.len() == self.size {

omnipaxos/src/unicache/lru_cache.rs

@@ -98,7 +98,7 @@ where
     }
 
     fn try_encode(&mut self, field: &Encodable) -> MaybeEncoded<Encodable, Encoded> {
-        match self.lru_cache_encoder.get(&field) {
+        match self.lru_cache_encoder.get(field) {
             Some(encoding) => MaybeEncoded::<Encodable, Encoded>::Encoded(encoding.clone()),
             None => {
                 if self.lru_cache_encoder.len() == self.size {
@@ -159,7 +159,7 @@ mod serialization {
         {
             let len = self.0.len();
             let mut seq = serializer.serialize_seq(Some(len))?;
-            let _ = self.0.iter().rev().for_each(|item| {
+            self.0.iter().rev().for_each(|item| {
                 seq.serialize_element(&item).unwrap();
             });
             seq.end()
@@ -185,8 +185,8 @@ mod serialization {
     impl<Encodable, Encoded> LruWrapperVisitor<Encodable, Encoded> {
         fn new() -> Self {
             Self {
-                _k: PhantomData::default(),
-                _v: PhantomData::default(),
+                _k: PhantomData,
+                _v: PhantomData,
             }
         }
     }

omnipaxos_macros/src/lib.rs

@@ -40,10 +40,8 @@ pub fn entry_derive(input: TokenStream) -> TokenStream {
 ///
 /// # Attributes
 /// * `encoding(T)`: (Optional) The type for what the annotated field should be encoded as. The default is `u8`.
-/// * `size(usize)`: (Optional) The size of the cache for this field. Should not be larger than the max size of the encoding type, e.g., if `encoding(u8)` is used, the max size should be 255.
-/// The default value is `u8::MAX`.
-/// * `cache(C)`: (Optional) The cache implementation which is a type `C: UniCache`. To use one of the provided implementations, simply use `cache(lru)` or `cache(lfu)`.
-/// The default uses `lru` (least-recently-used) eviction policy.
+/// * `size(usize)`: (Optional) The size of the cache for this field. Should not be larger than the max size of the encoding type, e.g., if `encoding(u8)` is used, the max size should be 255. Default is u8::MAX.
+/// * `cache(C)`: (Optional) The cache implementation which is a type `C: UniCache`. `cache(lru)` or `cache(lfu)` are provided out of the box. The default is `lru` (least-recently-used) eviction policy.
 ///
 /// ## Usage
 ///