BUG/MINOR: pprof handler should be called in sync loop

pprof handler should be called in sync loop (as part of updateHandlers list)
instead of being called only once in startup handelrs. This is required
in order to keep the pprof config (backend + route) in haproxy cfg.

Author: Mo3m3n

controller/handler.go

@@ -49,6 +49,10 @@ func (c *HAProxyController) initHandlers() {
 		handler.PatternFiles{},
 		handler.Refresh{},
 	}
+	if c.OSArgs.PprofEnabled {
+		c.updateHandlers = append(c.updateHandlers, handler.Pprof{})
+	}
+	c.updateHandlers = append(c.updateHandlers, handler.Refresh{})
 }
 
 func (c *HAProxyController) startupHandlers() error {
@@ -66,9 +70,6 @@ func (c *HAProxyController) startupHandlers() error {
 	if c.OSArgs.External {
 		handlers = append(handlers, handler.GlobalCfg{})
 	}
-	if c.OSArgs.PprofEnabled {
-		handlers = append(handlers, handler.Pprof{})
-	}
 	for _, handler := range handlers {
 		_, err := handler.Update(c.Store, &c.Cfg, c.Client)
 		if err != nil {

controller/handler/pprof.go

@@ -29,21 +29,24 @@ type Pprof struct {
 func (h Pprof) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAProxyClient) (reload bool, err error) {
 	pprofBackend := "pprof"
 
-	err = api.BackendCreate(models.Backend{
-		Name: pprofBackend,
-		Mode: "http",
-	})
+	_, err = api.BackendGet(pprofBackend)
 	if err != nil {
-		return
-	}
-	err = api.BackendServerCreate(pprofBackend, models.Server{
-		Name:    "pprof",
-		Address: "127.0.0.1:6060",
-	})
-	if err != nil {
-		return
+		err = api.BackendCreate(models.Backend{
+			Name: pprofBackend,
+			Mode: "http",
+		})
+		if err != nil {
+			return
+		}
+		err = api.BackendServerCreate(pprofBackend, models.Server{
+			Name:    "pprof",
+			Address: "127.0.0.1:6060",
+		})
+		if err != nil {
+			return
+		}
+		logger.Debug("pprof backend created")
 	}
-	logger.Debug("pprof backend created")
 	err = route.AddHostPathRoute(route.Route{
 		BackendName: pprofBackend,
 		Path: &store.IngressPath{