BUG/MINOR: fix GET default sections with full_section=true

the parameter full_section was ignored for /v3/services/haproxy/configuration/defaults endpoint

Signed-off-by: Vincent Gramer <vgramer@haproxy.com>

Author: vgramer

e2e/tests/defaults/data/haproxy.cfg

@@ -9,25 +9,15 @@ global
     group       haproxy
     stats socket /var/lib/haproxy/stats level admin
 
-defaults mydefaults
-    mode                    http
-    log                     global
-    option                  httplog
-    option                  dontlognull
-    option http-server-close
-    option forwardfor       except 127.0.0.0/8
-    option                  redispatch
-    retries                 3
-    timeout http-request    10s
-    timeout queue           1m
-    timeout connect         10s
-    timeout client          1m
-    timeout server          1m
-    timeout http-keep-alive 10s
-    timeout check           10s
-    maxconn                 3000
-
-defaults unnamed_defaults_1
-    mode http
-    balance roundrobin
-    timeout client 30000
+defaults
+    mode               http
+    log                global
+    option             httplog
+    option             dontlognull
+    option             forwardfor except 127.0.0.0/8
+    option             redispatch
+    retries            3
+    timeout connect    10s
+    timeout client     300s
+    timeout server     300s
+    maxconn            5000

e2e/tests/defaults/get.bats

@@ -27,12 +27,35 @@ load 'utils/_helpers'
 @test "defaults: Return a list of defaults configurations" {
   resource_get "$_DEFAULTS_BASE_PATH"
   assert_equal "$SC" 200
+
+  # log_target_list is a child resource, it should not be filled when full_section=false
+  assert_equal "$(get_json_path "$BODY" ".[] | select(.name | contains(\"unnamed_defaults_1\")).log_target_list.[0].global")" "null"
+}
+
+@test "default: return a list of defaults configurations with full section" {
+  resource_get "$_DEFAULTS_BASE_PATH" "full_section=true"
+  assert_equal "$SC" 200
+
+  # log_target_list is a child resource, it should be filled when full_section=true
+  assert_equal "$(get_json_path "$BODY" ".[] | select(.name | contains(\"unnamed_defaults_1\")).log_target_list.[0].global")" "true"
 }
 
 @test "defaults: Return a defaults configuration" {
   resource_get "$_DEFAULTS_BASE_PATH/unnamed_defaults_1"
   assert_equal "$SC" 200
   assert_equal "$(get_json_path "$BODY" '.name')" "unnamed_defaults_1"
+
+  # log_target_list is a child resource, it should not be filled when full_section=false
+  assert_equal "$(get_json_path "$BODY" ".log_target_list.[0].global")" "null"
+}
+
+@test "defaults: Return a defaults configuration with full section" {
+  resource_get "$_DEFAULTS_BASE_PATH/unnamed_defaults_1"  "full_section=true"
+  assert_equal "$SC" 200
+  assert_equal "$(get_json_path "$BODY" '.name')" "unnamed_defaults_1"
+
+  # log_target_list is a child resource, it should be filled when full_section=true
+  assert_equal "$(get_json_path "$BODY" ".log_target_list.[0].global")" "true"
 }
 
 @test "defaults: Return a named defaults configuration that does not exist" {

handlers/defaults.go

@@ -126,21 +126,15 @@ func (h GetDefaultsSectionsHandlerImpl) Handle(params defaults.GetDefaultsSectio
 		t = *params.TransactionID
 	}
 
-	configuration, err := h.Client.Configuration()
-	if err != nil {
-		e := misc.HandleError(err)
-		return defaults.NewGetDefaultsSectionsDefault(int(*e.Code)).WithPayload(e)
-	}
-
-	_, fs, err := configuration.GetDefaultsSections(t)
+	_, fs, err := h.getDefaultsSections(params, t)
 	if err != nil {
 		e := misc.HandleError(err)
 		return defaults.NewGetDefaultsSectionsDefault(int(*e.Code)).WithPayload(e)
 	}
 	return defaults.NewGetDefaultsSectionsOK().WithPayload(fs)
 }
 
-func (h *GetDefaultsSectionsHandlerImpl) getDefaultsSections(params defaults.GetDefaultsSectionParams, t string) (int64, models.DefaultsSections, error) {
+func (h *GetDefaultsSectionsHandlerImpl) getDefaultsSections(params defaults.GetDefaultsSectionsParams, t string) (int64, models.DefaultsSections, error) {
 	configuration, err := h.Client.Configuration()
 	if err != nil {
 		return 0, nil, err