Update deps and instructions for hapi v.16 scrub #7
Conversation
|
| srv.stop(done); | ||
| }); | ||
|
|
||
| request.on('push', () => next(new Error('Should not make it here'))); |
There was a problem hiding this comment.
Returning an error wont do anything! You'd have to at least throw it. I think that next was possibly supposed to be done.
There was a problem hiding this comment.
ay, gotcha. thanks for pointing that out. slopslopslop. fixing now!
test/index.js
Outdated
| }); | ||
|
|
||
| request.on('push', () => next(new Error('Should not make it here'))); | ||
| request.on('push', () => new Error('Should not make it here')); |
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "hapi": ">=10 <16" | ||
| "hapi": ">=10 <17" |
There was a problem hiding this comment.
If this doesn't work yet on hapi v16, then no need for this change.
There was a problem hiding this comment.
oh bugger, extra sloppy. sorry about that, thanks for catching 🙏
| node_js: | ||
| - "4" | ||
| - "6" | ||
| - "8.7.0" |
There was a problem hiding this comment.
Ohhh totally missed your commit message, sorry! Wow!! I would definitely have expected that to be a semver major!
There was a problem hiding this comment.
oh man, yea. took me a bit to peek through their changelog to sort that out. 🎺
1 similar comment
3 participants
No description provided.