Skip to content

Commit 06b57f9

Browse files
jedirezageek
authored andcommitted
don't skip annotating node unless fully bypassed (#620)
1 parent 7236bbd commit 06b57f9

File tree

3 files changed

+41
-1
lines changed

3 files changed

+41
-1
lines changed

lib/coverage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ internals.instrument = function (filename) {
109109

110110
// Coverage status
111111

112-
if (bypass[node.range[0]]) {
112+
if (bypass[node.range[0]] && bypass[node.range[1]]) {
113113
return;
114114
}
115115

test/coverage.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,19 @@ describe('Coverage', () => {
140140
done();
141141
});
142142

143+
it('bypasses marked code and reports misses correctly', (done) => {
144+
145+
const Test = require('./coverage/bypass-misses');
146+
Test.method(1);
147+
148+
const cov = Lab.coverage.analyze({ coveragePath: Path.join(__dirname, 'coverage/bypass-misses') });
149+
expect(Math.floor(cov.percent)).to.equal(93);
150+
expect(cov.sloc).to.equal(15);
151+
expect(cov.misses).to.equal(1);
152+
expect(cov.hits).to.equal(14);
153+
done();
154+
});
155+
143156
it('ignores non-matching files', (done) => {
144157

145158
require('./coverage/exclude/ignore');

test/coverage/bypass-misses.js

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
'use strict';
2+
3+
// Load modules
4+
5+
6+
// Declare internals
7+
8+
const internals = {};
9+
10+
/*$lab:coverage:off$*/const noop = function () {};
11+
12+
const /*$lab:coverage:on$*/FiveMath = function () {
13+
14+
this.addFive = function (value) {
15+
16+
return value + 5;
17+
};
18+
19+
this.subtractFive = function (value) {
20+
21+
return value - 5;
22+
};
23+
};
24+
25+
const fiveMath = new FiveMath();
26+
27+
exports.method = fiveMath.addFive;

0 commit comments

Comments
 (0)