Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native 405 support #1534

Closed
hueniverse opened this issue Mar 28, 2014 · 3 comments
Closed

Native 405 support #1534

hueniverse opened this issue Mar 28, 2014 · 3 comments
Assignees
Labels
feature New functionality or improvement

Comments

@hueniverse
Copy link
Contributor

No description provided.

@hueniverse
Copy link
Contributor Author

Too expensive.

@csrl
Copy link

csrl commented Feb 5, 2015

It is really annoying to have to add routes for every method explicitly responding with a 405 just so we get proper status responses.

Are you against this feature, or just the proposed implementation? Could we re-open this issue and look for a better implementation?

@hueniverse
Copy link
Contributor Author

I generally find 405 to be a pointless status code. To implement it you have to check every 404 for potential 405 which means you have to go through the entire routing table. Even if you "precompile" this data, it is still an extra lookup on every 404.

It should be possible to implement this in a plugin. If you need built-in support in the router, I'm open to extra functionality in the call module.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants