Allow initializing connectionless. Closes #3325

Author: hueniverse

lib/server.js

@@ -182,6 +182,10 @@ internals.Server.prototype.start = function (callback) {
     Hoek.assert(typeof callback === 'function', 'Missing required start callback function');
     const nextTickCallback = Hoek.nextTick(callback);
 
+    if (!this.connections.length) {
+        return nextTickCallback(new Error('No connections to start'));
+    }
+
     if (this._state === 'initialized' ||
         this._state === 'started') {
 
@@ -224,10 +228,6 @@ internals.Server.prototype.initialize = function (callback) {
     Hoek.assert(typeof callback === 'function', 'Missing required start callback function');
     const nextTickCallback = Hoek.nextTick(callback);
 
-    if (!this.connections.length) {
-        return nextTickCallback(new Error('No connections to start'));
-    }
-
     if (this._registring) {
         return nextTickCallback(new Error('Cannot start server before plugins finished registration'));
     }
@@ -249,12 +249,8 @@ internals.Server.prototype.initialize = function (callback) {
 
     // Start cache
 
-    const each = (cache, next) => {
-
-        this._caches[cache].client.start(next);
-    };
-
     const caches = Object.keys(this._caches);
+    const each = (cache, next) => this._caches[cache].client.start(next);
     Items.parallel(caches, each, (err) => {
 
         if (err) {

npm-shrinkwrap.json

@@ -2,7 +2,7 @@
   "name": "hapi",
   "description": "HTTP Server framework",
   "homepage": "http://hapijs.com",
-  "version": "15.0.1",
+  "version": "15.0.2",
   "repository": {
     "type": "git",
     "url": "git://github.com/hapijs/hapi"

package.json

@@ -2870,6 +2870,49 @@ describe('Plugin', () => {
                 });
             });
         });
+
+        it('errors when missing dependencies on connection added after start', (done) => {
+
+            const a = function (srv, options, next) {
+
+                return next();
+            };
+
+            a.attributes = {
+                name: 'a'
+            };
+
+            const b = function (srv, options, next) {
+
+                srv.dependency('a');
+                return next();
+            };
+
+            b.attributes = {
+                name: 'b'
+            };
+
+            const server = new Hapi.Server();
+            server.connection();
+            server.register([a, b], (err) => {
+
+                expect(err).to.not.exist();
+                server.start((err) => {
+
+                    expect(err).to.not.exist();
+                    const select = server.connection();
+                    select.register(b, (err) => {
+
+                        expect(err).to.not.exist();
+                        server.start((err) => {
+
+                            expect(err).to.be.an.error(`Plugin b missing dependency a in connection: ${select.info.uri}`);
+                            server.stop(done);
+                        });
+                    });
+                });
+            });
+        });
     });
 
     describe('encoder()', () => {

test/plugin.js

@@ -52,6 +52,19 @@ describe('Server', () => {
         done();
     });
 
+    describe('initialize()', () => {
+
+        it('allows initializing a server without connections', (done) => {
+
+            const server = new Hapi.Server();
+            server.initialize((err) => {
+
+                expect(err).to.not.exist();
+                done();
+            });
+        });
+    });
+
     describe('start()', () => {
 
         it('starts and stops', (done) => {