Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to wgpu 0.15.1, winit 0.28.1, egui 0.21 #1549

Closed
hannobraun opened this issue Jan 30, 2023 · 5 comments · Fixed by #1587
Closed

Upgrade to wgpu 0.15.1, winit 0.28.1, egui 0.21 #1549

hannobraun opened this issue Jan 30, 2023 · 5 comments · Fixed by #1587
Labels
topic: display Displaying Fornjot models type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

This upgrade requires some manual changes. See #1545.
@hannobraun hannobraun added topic: display Displaying Fornjot models type: development Work to ease development or maintenance, without direct effect on features or bugs labels Jan 30, 2023
@hannobraun hannobraun mentioned this issue Jan 30, 2023
Closed
@hannobraun
Copy link
Owner Author

This is blocked on a new version of egui-wgpu. They have already upgraded, so it's just a question of waiting.

@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Jan 30, 2023
@hannobraun
Copy link
Owner Author

There are new versions of winit, but upgrading is blocked by egui-winit. They have already upgraded, so we're only waiting on a new release.

Since both the wgpu and winit upgrades are blocked on egui, I'm adding the winit upgrade to this issue.

@hannobraun hannobraun changed the title Upgrade to wgpu 0.15.0 Upgrade to wgpu 0.15.0, winit 0.28.1 Feb 6, 2023
@hannobraun hannobraun mentioned this issue Feb 6, 2023
Closed
@hannobraun
Copy link
Owner Author

A new version of egui is out (#1577, #1578, #1581). This is no longer blocked, as it should now be possible to upgrade everything together.

@hannobraun hannobraun changed the title Upgrade to wgpu 0.15.0, winit 0.28.1 Upgrade to wgpu 0.15.1, winit 0.28.1, egui 0.21 Feb 13, 2023
@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Feb 13, 2023
This was referenced Feb 13, 2023
Closed
Closed
Closed
Closed
@hannobraun
Copy link
Owner Author

Ah, this is still blocked, on wgpu_glyph. There's already an open pull request: hecrj/wgpu_glyph#95

@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Feb 13, 2023
@hannobraun
Copy link
Owner Author

Turns out we aren't really using wgpu_glyph anymore, and the dependency can be removed easily. Pull request incoming!

@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Feb 14, 2023
@hannobraun hannobraun mentioned this issue Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: display Displaying Fornjot models type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to latest wgpu, winit, egui hannobraun/fornjot
1 participant
@hannobraun