Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add nametags for minions as soon as they are placed #445

Merged

Conversation

brandonwamboldt
Copy link
Contributor

The fix may seem a bit strange but there wasn't a good way to detect if a minion was actually placed or not using the PlayerInteractEvent as it would be triggered by clicking on chests, doors, etc. I didn't use the existing hook for InputEvent.MouseInputEvent since it didn't have easy access to the block face that was clicked, which is required to figure out the actual position of the minion.

I didn't add any sort of time based checks because I couldn't find a use case where this would be incorrectly triggered. Let me know if I missed something though.

@hannibal002 hannibal002 self-requested a review September 8, 2023 15:05
@hannibal002 hannibal002 merged commit dddd91d into hannibal002:beta Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants