-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Corpse Tracker #2306
Feature: Corpse Tracker #2306
Conversation
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine in game (got 1.5b profit while testing lol)
couple smaller problems, not related to corpse but bucket:
the color of the bracket is wrong:
there is no option to select "no ´corpse type selected, snow all instead".
please make it a "click to switch through options" selection, not a list. like in fishing profit tracker.
per default hide empty brackets from this list.
src/main/java/at/hannibal2/skyhanni/utils/tracker/BucketedItemTrackerData.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/glacitemineshaft/CorpseTracker.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/utils/tracker/SkyHanniBucketedItemTracker.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/glacitemineshaft/CorpseTracker.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/glacitemineshaft/CorpseTracker.kt
Outdated
Show resolved
Hide resolved
bracket color being wrong was fixed in ab6d21a None option was added in 16bcf3f - but was done as a list, should be fixed now. |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
f149658
to
9d08ee6
Compare
Conflicts have been resolved! 🎉 |
What
https://discord.com/channels/997079228510117908/1230761536176521249
Adds a source-addressable tracker for Glacite Mineshaft Corpses.
Images
Due to not having any actual loot strings for corpses, the tracker is displaying Nucleus run loot, but 🤷
All Loot Buckets (sources), will merge loot from all buckets
"Bucket" (source) selectors, similar to the Display Mode toggles, that will only appear while inventory.
With a "Bucket" selected, only display loot that came from that 'type'
Changelog New Features
Changelog Technical Details