Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Corpse Tracker #2306

Merged
merged 25 commits into from
Sep 10, 2024
Merged

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Aug 4, 2024

What

https://discord.com/channels/997079228510117908/1230761536176521249
Adds a source-addressable tracker for Glacite Mineshaft Corpses.

Images

Due to not having any actual loot strings for corpses, the tracker is displaying Nucleus run loot, but 🤷

All Loot Buckets (sources), will merge loot from all buckets
image

"Bucket" (source) selectors, similar to the Display Mode toggles, that will only appear while inventory.
image

With a "Bucket" selected, only display loot that came from that 'type'
image

Changelog New Features

  • Added Tracker for Glacite Corpses. - Daveed
    • Tracks overall loot and loot per type.

Changelog Technical Details

  • Added an abstract "bucketed" tracker that can store where items came from. - Daveed
    • Takes an enum in instantiation and has built-in logic for swapping display types.

@DavidArthurCole DavidArthurCole marked this pull request as ready for review August 5, 2024 06:45
@hannibal002 hannibal002 added this to the Version 0.27 milestone Aug 8, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Aug 26, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Sep 7, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in game (got 1.5b profit while testing lol)
couple smaller problems, not related to corpse but bucket:
the color of the bracket is wrong:
image

there is no option to select "no ´corpse type selected, snow all instead".

please make it a "click to switch through options" selection, not a list. like in fishing profit tracker.
per default hide empty brackets from this list.

@DavidArthurCole
Copy link
Contributor Author

works fine in game (got 1.5b profit while testing lol) couple smaller problems, not related to corpse but bucket: the color of the bracket is wrong: image

there is no option to select "no ´corpse type selected, snow all instead".

please make it a "click to switch through options" selection, not a list. like in fishing profit tracker. per default hide empty brackets from this list.

bracket color being wrong was fixed in ab6d21a

None option was added in 16bcf3f - but was done as a list, should be fixed now.

@DavidArthurCole
Copy link
Contributor Author

gif

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 10, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 10, 2024
@hannibal002 hannibal002 merged commit 2f6121b into hannibal002:beta Sep 10, 2024
2 of 4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 10, 2024
@DavidArthurCole DavidArthurCole deleted the CorpseTracker branch September 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants