Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hoppity Call Warning #2272

Merged
merged 32 commits into from
Sep 8, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jul 29, 2024

What

Context: https://discord.com/channels/997079228510117908/1264604838994378875
Add an option to get screen-flashed and dinged when Hoppity calls via abiphone to sell you a rabbit.
Largely reuses configuration code from stray rabbit warnings.
Also adds a config hotkey for picking up the Hoppity call.

The warning will stop either after 10 seconds, or when the player picks up the call.

Images

Config option(s)
image

Short Video
https://www.youtube.com/watch?v=F5fQ7JjEFa4

Changelog New Features

  • Added optional warning when Hoppity calls you with a rabbit to sell. - Daveed
  • Added hotkey for picking up Abiphone calls from Hoppity. - Daveed

Changelog Technical Details

  • Rebased Hoppity config to be in its own package. - Daveed

@hannibal002 hannibal002 added this to the Version 0.27 milestone Jul 29, 2024
@DavidArthurCole
Copy link
Contributor Author

Ugh. The UUID for calling back is randomized - I'm gonna have to try to extract it from a chat message I guess?

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 25, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 25, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Aug 25, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 25, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Aug 25, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good overall. Will not test in game for obvious reasons.

Please fix the many small suggestions, then ill merge it.

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannibal002 hannibal002 merged commit 3db3627 into hannibal002:beta Sep 8, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 8, 2024
@DavidArthurCole DavidArthurCole deleted the HoppityCallWarning branch September 8, 2024 16:26
MTOnline69 pushed a commit to MTOnline69/SkyHanni that referenced this pull request Sep 11, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants