-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Hoppity Call Warning #2272
Feature: Hoppity Call Warning #2272
Conversation
a04451a
to
dda5275
Compare
Ugh. The UUID for calling back is randomized - I'm gonna have to try to extract it from a chat message I guess? |
f886b07
to
ac7972c
Compare
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
92ea88f
to
44df886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good overall. Will not test in game for obvious reasons.
Please fix the many small suggestions, then ill merge it.
src/main/java/at/hannibal2/skyhanni/config/features/event/hoppity/HoppityCallWarningConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
What
Context: https://discord.com/channels/997079228510117908/1264604838994378875
Add an option to get screen-flashed and dinged when Hoppity calls via abiphone to sell you a rabbit.
Largely reuses configuration code from stray rabbit warnings.
Also adds a config hotkey for picking up the Hoppity call.
The warning will stop either after 10 seconds, or when the player picks up the call.
Images
Config option(s)
Short Video
https://www.youtube.com/watch?v=F5fQ7JjEFa4
Changelog New Features
Changelog Technical Details