Feature: Last server #2046
Merged
Feature: Last server #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
jani270
added
the
Soon
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/misc/MiscConfig.java
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
hannibal002
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Does not work for me. LorenzUtils.inSkyBlock is false at the moment the world change event fires.
I suggest an different approach:
periodically check the value of HypixelData.serverId, compare against last known value. If the value changes, assume server switch. This should also work faster than 5 seconds after joining. Also fixed the potential bug when a user quickly swaps servers in under 5 seconds.
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
github-actions
bot
removed
the
Soon
MTOnline69
pushed a commit
to MTOnline69/SkyHanni
that referenced
this pull request
Sep 11, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This Pull Request adds a feature, which reminds the player if he joins a server he joined previously (customisable time).
Images
Changelog New Features