Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: warning when upgrade avaliavble #1642

Merged
merged 19 commits into from
May 2, 2024

Conversation

catgirlseraid
Copy link
Contributor

@catgirlseraid catgirlseraid commented May 2, 2024

Dependencies

What

Adds a chat message and a sound when a chocolate factory upgrade is avaliable to purchase

Images

image

image

Changelog New Features

  • Added warning when Chocolate Factory upgrade is available. - seraid

@catgirlseraid catgirlseraid changed the title Soundonupgrade warning when upgrade avaliavble May 2, 2024
@CalMWolfs CalMWolfs self-requested a review May 2, 2024 05:17
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@CalMWolfs CalMWolfs requested a review from hannibal002 May 2, 2024 05:18
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label May 2, 2024
@CalMWolfs CalMWolfs added this to the Version 0.25 milestone May 2, 2024
@hannibal002 hannibal002 added the Waiting on Dependency PR waiting for a dependency pr to be merged label May 2, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 removed the Waiting on Dependency PR waiting for a dependency pr to be merged label May 2, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryDataLoader.kt
#	src/main/java/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryTooltip.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Conflicts have been resolved! 🎉

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@hannibal002 hannibal002 merged commit 382f226 into hannibal002:beta May 2, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 2, 2024
@hannibal002 hannibal002 changed the title warning when upgrade avaliavble Feature: warning when upgrade avaliavble May 2, 2024
@catgirlseraid catgirlseraid deleted the soundonupgrade branch July 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants