Feature: Mineshaft click to gfs ascension rope #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/at/hannibal2/skyhanni/features/mining/MiningNotifications.kt
Outdated
Show resolved
Hide resolved
|
This new function, I don't like. Since creating a primitivItem stack is simple to do and also is possible to cach in this case. The method btw. is .toPrimitivStack for NeuInternalNames (not sure if I mistyped the function name). |
hannibal002
added
the
Soon
hannibal002
requested changes
Apr 25, 2024
src/main/java/at/hannibal2/skyhanni/config/features/mining/MiningNotificationsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/MiningNotifications.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
…ingNotificationsConfig.java Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
…fications.kt Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
…feature/gfs-ascension-rop # Conflicts: # src/main/java/at/hannibal2/skyhanni/api/GetFromSackAPI.kt
hannibal002
approved these changes
Apr 25, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This Pull Request adds a feature which allows to user to get an Ascension Rope from sack.
With this Item you can now leave the mineshaft and still get the leaving rewards.
Images
I changed the text to yellow, didnt bother getting a new screenshot
Changelog New Features